librustc/driver: expose build information of rustc. #17682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,8 +51,7 @@ pub fn host_triple() -> &'static str { | |||
| // Instead of grabbing the host triple (for the current host), we grab (at | |||
| // compile time) the target triple that this rustc is built with and | |||
| // calling that (at runtime) the host triple. | |||
| (option_env!("CFG_COMPILER_HOST_TRIPLE")). | |||
| expect("CFG_COMPILER_HOST_TRIPLE") | |||
| env!("CFG_COMPILER_HOST_TRIPLE") | |||
There was a problem hiding this comment.
Could this stay as option_env! actually? It's often useful when compiling rustc by hand to not have to define all these environment variables.
There was a problem hiding this comment.
@alexcrichton I felt too insecure when I saw Option::expect(). I'll use .unwrap_or("unknown-target-triple") instead.
There was a problem hiding this comment.
It's ok to fail at runtime (there's no good default for this), it's just there with an option to make building by hand a little easier.
CFG_RELEASE, CFG_VER_HASH and CFG_VER_DATE were only available as an output to stdout from the driver::version() function that had an inconvenient signature.
nodakai
force-pushed
the
librustc-handy-version
branch
from
cf521bd to
1dfb23f
Compare
|
@alexcrichton extern crate rustc;
use rustc::driver;
fn main() {
println!("{}", driver::release_str());
println!("{}", driver::commit_hash_str());
println!("{}", driver::commit_date_str());
println!("{}", driver::driver::host_triple());
}outputs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFG_RELEASE, CFG_VER_HASH and CFG_VER_DATE were only available
as an output to stdout from the driver::version() function
that had an inconvenient signature.
Also, if one failed to set an env var CFG_COMPILER_HOST_TRIPLE at
compile time, the compilation fails.
Now we can easily check the exact version of rustc running at playpen.
I would appreciate if someone could improve my English in the rustdoc comments!