Skip to content

Add {Imm,M}utableIntSlice #17748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2014
Merged

Add {Imm,M}utableIntSlice #17748

merged 1 commit into from
Oct 8, 2014

Conversation

mahkoh
Copy link
Contributor

@mahkoh mahkoh commented Oct 3, 2014

No description provided.

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@alexcrichton
Copy link
Member

r? @aturon

@aturon
Copy link
Member

aturon commented Oct 8, 2014

@mahkoh Thanks for the PR!

A couple of notes:

I'd prefer for this not to close [https://github.com//issues/17375], because I think your original idea of from_utf8 taking (something like) BytesContainer is ultimately a better way to go.

Also, I would prefer to put this in core::slice, since it matches the other slice extension traits that are already there.

Otherwise, looks great!

@mahkoh
Copy link
Contributor Author

mahkoh commented Oct 8, 2014

Updated

@aturon
Copy link
Member

aturon commented Oct 8, 2014

Sorry, one other thing: can you add #[experimental] to the traits and impl blocks?

@mahkoh
Copy link
Contributor Author

mahkoh commented Oct 8, 2014

Updated.

bors added a commit that referenced this pull request Oct 8, 2014
@bors bors closed this Oct 8, 2014
@bors bors merged commit bd52790 into rust-lang:master Oct 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants