Skip to content

rustdoc: hide private traits in strip-private pass #17846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2014

Conversation

tomjakubowski
Copy link
Contributor

Fix #16563

@tomjakubowski
Copy link
Contributor Author

I've verified that this hides traits which:

  • Are private at the crate root or private in a module
  • Are public in a private module

And does not hide traits which:

  • Are public at the crate root or public in a public module
  • Are public in a private module and re-exported

@tomjakubowski
Copy link
Contributor Author

@alexcrichton
Copy link
Member

Sorry for being a little slow on this, thanks @tomjakubowski! r=me with a rebase.

@sfackler
Copy link
Member

It'd be nice to update the missing_doc lint with the same logic.

@tomjakubowski tomjakubowski force-pushed the rustdoc-hide-private-traits branch from 76dde9a to 370c9c5 Compare October 21, 2014 17:20
@tomjakubowski
Copy link
Contributor Author

Rebased but I'm going to update missing_doc later today.

bors added a commit that referenced this pull request Oct 22, 2014
@bors bors closed this Oct 22, 2014
@bors bors merged commit 370c9c5 into rust-lang:master Oct 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private trait appears in the documentation
4 participants