Renamed AsciiStr::to_lower and AsciiStr::to_upper #17947
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. |
| @@ -319,12 +319,20 @@ pub trait AsciiStr { | |||
| /// Convert to a string. | |||
| fn as_str_ascii<'a>(&'a self) -> &'a str; | |||
|
|
|||
| /// Convert to vector representing a lower cased ascii string. | |||
| #[allow(missing_doc)] | |||
There was a problem hiding this comment.
I think the convention we've been adopting here is to make the doc comment the deprecated message.
There was a problem hiding this comment.
Done. Should I squash then push -f to force update so they are squashed on my remote?
|
Why is it to_lowercase and not to_lower? I know that the Char trait has the longer names, but I doubt the ergonomics of such expressions. |
|
should this have a [breaking-changes] note? |
|
@sinistersnare Done |
lukemetz
force-pushed
the
master
branch
2 times, most recently
from
771d3c6 to
29cd4dc
Compare
|
@lukemets: the Otherwise, this looks good to me! Let me know when you've updated the message, and I'll send it to @bors. |
Now AsciiStr::to_lowercase and AsciiStr::to_uppercase to match Ascii trait. [breaking-change]
|
@aturon Done! Thanks for the help! |
AsciiStr::to_lower is now AsciiStr::to_lowercase and AsciiStr::to_upper is AsciiStr::to_uppercase to match Ascii trait. Part of issue #17790. This is my first pull request so let me know if anything is incorrect. Thanks! [breaking-changes]
Always show error lifetime arguments as `'_` Fixes rust-lang#17947 Changed error lifetime argument presentation in non-test environment to `'_` and now showing them even if all of args are error lifetimes. This also influenced some of the other tests like `extract_function.rs`, `predicate.rs` and `type_pos.rs`. Not sure whether I need to refrain from adding lifetimes args there. Happy to fix if needed
AsciiStr::to_lower is now AsciiStr::to_lowercase and AsciiStr::to_upper is AsciiStr::to_uppercase to match Ascii trait.
Part of issue #17790.
This is my first pull request so let me know if anything is incorrect.
Thanks!
[breaking-changes]