Make bors check compiletest builds from both stage0 and stage1 rustc
#18012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rustc. ---- To reproduce issue on commit ba24610 it does not suffice to add just `check-build-compiletest` to `check-secondary`; one must also ensure that `check-build-compiletest` precedes the satisification of the `check` rule. Otherwise hidden dependencies of `compiletest` would end up getting satisfied when make builds `rustc` at each stage in order to eventually run `check-stage2`. So to handle that I moved `check-secondary` before `check` in the `check-all` rule that bors uses, and for good measure, I also put `check-build-compiltest` at the front of the `check-secondary` rule's dependencies. My understanding is that running `check-secondary` should be relatively cheap, and thus such a reordering will not hurt bors. ---- Fix rust-lang#17883.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 13, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Sep 25, 2024
fix: Fix lifetime elision inlay hints breaking for ranged requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make bors check
compiletestbuilds from both stage0 and stage1 rustcTo reproduce issue on commit ba24610
it does not suffice to add just
check-build-compiletesttocheck-secondary; one must also ensure thatcheck-build-compiletestprecedes the satisification of the
checkrule.Otherwise hidden dependencies of
compiletestwould end up gettingsatisfied when make builds
rustcat each stage in order toeventually run
check-stage2.So to handle that I moved
check-secondarybeforecheckin thecheck-allrule that bors uses, and for good measure, I also putcheck-build-compiltestat the front of thecheck-secondaryrule'sdependencies.
My understanding is that running
check-secondaryshould berelatively cheap, and thus such a reordering will not hurt bors.
Fix #17883.