Bring back the dylib kind of the link attribute #19000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that the implementation is actually currently in error and may need to be fixed (may have been lost in a rebase). Would you mind adding a case for |
IvanUkhov
changed the title
|
@alexcrichton, thanks for the clarification. I have updated the pull request. Please have a look. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
dylibseems to be no longer an option for thekindkey of thelinkattribute.UPDATE: It should be the other way around: It seems
dylibhas been lost as a possible variant of thekindkey of thelinkattribute. See the comment below.Regards,
Ivan