Rename col! to column!.
#19071
Merged
Rename col! to column!.
#19071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -552,17 +552,17 @@ pub mod builtin { | |||
| /// A macro which expands to the column number on which it was invoked. | |||
| /// | |||
| /// The expanded expression has type `uint`, and the returned column is not | |||
| /// the invocation of the `col!()` macro itself, but rather the first macro | |||
| /// the invocation of the `column!()` macro itself, but rather the first macro | |||
| /// invocation leading up to the invocation of the `col!()` macro. | |||
This macro is very rarely used, so there is no need (and it is better) for it to avoid the abbreviation. Closes rust-lang/rfcs#467. [breaking-change]
bors
added a commit
that referenced
this pull request
Nov 20, 2014
This macro is very rarely used, so there is no need (and it is better) for it to avoid the abbreviation. Closes rust-lang/rfcs#467.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Feb 10, 2025
…niquely Previously it may have been possible for different completion items to produce colliding hashes, not because of the hash but because of how the items were serialized into byte streams for hashing. See rust-lang#19071 for details. The chances of that happening were low, if it was actually possible at all. Nevertheless, this commit ensures that it definitely can't happen. This commit uses a handful of techniques used to fix this, but they all boil down to "ensure this could be re-parsed". If it's possible to parse to recreate the original item, then by construction there is no chance of two different items getting serialized to identical byte streams.
lnicola
added a commit
to lnicola/rust
that referenced
this pull request
Feb 10, 2025
Fix rust-lang#19071: ensure `completion_item_hash` serializes items uniquely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro is very rarely used, so there is no need (and it is better)
for it to avoid the abbreviation.
Closes rust-lang/rfcs#467.