Skip to content

Fix c_char on ARM #19160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix c_char on ARM #19160

wants to merge 3 commits into from

Conversation

mahkoh
Copy link
Contributor

@mahkoh mahkoh commented Nov 20, 2014

c_char is u8 on ARM

[breaking-change]

closes #18597

Doesn't break any correct code.

Fix c_char on ARM
216e5a8 
c_char is u8 on ARM

[breaking-change]
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 22, 2014
@alexcrichton
rollup merge of rust-lang#19160: mahkoh/arm_char
6114db3 
c_char is u8 on ARM

[breaking-change]

-------

closes rust-lang#18597

Doesn't break any correct code.
@mahkoh
Copy link
Contributor Author

mahkoh commented Nov 23, 2014 

/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/os.rs:374:35: 374:49 error: mismatched types: expected `*const u8`, found `*const i8` (expected u8, found i8)
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/os.rs:374                 Some(CString::new(s as *const i8, false).as_bytes_no_nul().to_vec())
                                                                                                                               ^~~~~~~~~~~~~~

As expected.

@mahkoh
Copy link
Contributor Author

mahkoh commented Nov 24, 2014

Updated

@steveklabnik
Copy link
Member

@bstrie you r+'d the original PR, what do you think about cb91bf5?

@mahkoh mahkoh closed this Dec 8, 2014
@mahkoh mahkoh deleted the arm_char branch December 8, 2014 19:38
lnicola pushed a commit to lnicola/rust that referenced this pull request Feb 17, 2025
@Veykril
Merge pull request rust-lang#19160 from Veykril/push-f3601671f6a468a8…
e6eadd3 
…cc0774253ddaddff

Improve error recovery when method-calling an assoc function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARM c_char has the wrong type.
4 participants
@mahkoh @steveklabnik @bstrie @bors