Replace some verbose match statements with their if let equivalent.
#19405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No semantic changes, no enabling `if let` where it wasn't already enabled.
|
|
|
This PR is probably the best argument I've ever seen for if-let. |
|
−1,337 lines, nice! |
| cdata); | ||
| if let Some(impl_method_doc) = maybe_find_item(impl_item_def_id.node, items) { | ||
| match item_family(impl_method_doc) { | ||
| StaticMethod => { |
There was a problem hiding this comment.
Can't you also use if let here?
if let StaticMethod = item_family(impl_method_doc) {There was a problem hiding this comment.
Yep, plus a few other little spots I missed. Thanks!
bors
added a commit
that referenced
this pull request
Dec 1, 2014
No semantic changes, no enabling `if let` where it wasn't already enabled.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 28, 2025
minor: Remove unnecessary expansions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No semantic changes, no enabling
if letwhere it wasn't already enabled.