Prevent hashtable shrinking past INITIAL_CAPACITY on clear. #19486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HashMap::clear()` was failing to set the capacity to a power of 2, and could even go under INITIAL_CAPACITY! This broke invariants, and at times (see unit test) led to failure of sanity-checking asserts. This patch fixes that. Fixes rust-lang#19485
|
cc #19485 |
|
This change might be redundant with #18770 which is approved but bors' panic attacks are blocking. |
|
Should be. I'll keep this open till that lands. |
|
Landed. Might still be worth adding the test? |
|
Probably not. It was a bug triggered by complexity in hashtable growing and shrinking which is much simpler now. Testing this now would probably be overkill. @frankmcsherry can you confirm this is fixed, and close #19485 if it is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.