Remove all uses of feature(import_shadowing). #19511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use sys::retry; | ||
| use sys_common::{keep_going, eof, mkerr_libc}; | ||
|
|
||
| pub use path::PosixPath as Path; |
There was a problem hiding this comment.
This would break a public api. Should probably be deprecated instead of removed outright.
cc @aturon
There was a problem hiding this comment.
I've been told that src/libstd/sys is not a public api, so it's okay if we remove this.
|
Awesome work @eddyb, thanks! |
eddyb
force-pushed
the
no-shadow
branch
3 times, most recently
from
b7da8ef to
7070824
Compare
eddyb
force-pushed
the
no-shadow
branch
2 times, most recently
from
cdb4366 to
e4d9eb6
Compare
|
Needs a rebase |
|
@eddyb: want to rebase? |
eddyb
force-pushed
the
no-shadow
branch
2 times, most recently
from
8e60f69 to
e549317
Compare
|
|
||
| use super::BinaryHeap; | ||
| use vec::Vec; |
There was a problem hiding this comment.
Yessss. use vec::Vec is my secret nemesis.
eddyb
force-pushed
the
no-shadow
branch
4 times, most recently
from
d94e895 to
7fcf304
Compare
|
Collection stuff LGTM now. Everyone else happy with all the other changes? |
bors
added a commit
that referenced
this pull request
Dec 20, 2014
bors
added a commit
that referenced
this pull request
Dec 20, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 28, 2025
chore: clean up some FIXMEs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @erickt