-
Notifications
You must be signed in to change notification settings - Fork 13.3k
No need for feature gate directives for if_let
, while_let
, or tuple_indexing
anymore.
#19517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will need to wait on #19472 to make it into a snapshot as well, since the stage0 compiler will still thing that the gate is needed. |
Ah, I figured there was some reason these guys were left in there. My mistake! We can just let this sit/close it/whatever you'd like until that happens then. |
df665fc
to
c0d60a2
Compare
if_let
, while_let
, or tuple_indexing
anymore.
c0d60a2
to
58aa7fc
Compare
@alexcrichton When I rebase this on master and Thanks! |
You gotta wait for a snapshot to remove those things, yeah :( |
I thought that was the case! Anyway, yeah it looks like the referenced pull leaves the feature gates that I removed from the tests untouched, so I'll wait for it to land and then open a fresh PR to clean out any that happen to be remaining at that point. Thanks! |
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed. We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust. Closes rust-lang#19473.
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed. We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust. Closes rust-lang#19473.
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed. We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust. Closes rust-lang#19473.
As soon as #19472 lands (Edit: and makes it into a snapshot), we won't need to use
if let
,while_let
, ortuple indexing
feature gates anymore. This removes the last remaining instances that I could find throughout the source.Closes #19473.