Skip to content

No need for feature gate directives for if_let, while_let, or tuple_indexing anymore. #19517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

csouth3
Copy link
Contributor

@csouth3 csouth3 commented Dec 4, 2014

As soon as #19472 lands (Edit: and makes it into a snapshot), we won't need to use if let, while_let, or tuple indexing feature gates anymore. This removes the last remaining instances that I could find throughout the source.

Closes #19473.

@sfackler
Copy link
Member

sfackler commented Dec 4, 2014

This will need to wait on #19472 to make it into a snapshot as well, since the stage0 compiler will still thing that the gate is needed.

@csouth3
Copy link
Contributor Author

csouth3 commented Dec 4, 2014

Ah, I figured there was some reason these guys were left in there. My mistake! We can just let this sit/close it/whatever you'd like until that happens then.

@csouth3 csouth3 force-pushed the remove-featuregates branch from df665fc to c0d60a2 Compare December 6, 2014 00:56
@csouth3 csouth3 changed the title No need for feature gate directives for if_let or tuple_indexing anymore No need for feature gate directives for if_let, while_let, or tuple_indexing anymore. Dec 6, 2014
@csouth3 csouth3 force-pushed the remove-featuregates branch from c0d60a2 to 58aa7fc Compare December 7, 2014 02:23
@csouth3
Copy link
Contributor Author

csouth3 commented Dec 8, 2014

@alexcrichton When I rebase this on master and make check locally, I still get compilation failures asking me to add #[feature(tuple_indexing)] back. Does this PR depend on the snapshot registered by #19641? Taking a look, that PR actually takes care of removing some, but not all of the feature gates that I remove in this PR. Should I just defer to that PR?

Thanks!

@steveklabnik
Copy link
Member

You gotta wait for a snapshot to remove those things, yeah :(

@alexcrichton
Copy link
Member

Ah yes! I'll close this in favor of #19641 and @csouth3 would you mind resubmitting once it's landed? Thanks!

@csouth3
Copy link
Contributor Author

csouth3 commented Dec 8, 2014

I thought that was the case! Anyway, yeah it looks like the referenced pull leaves the feature gates that I removed from the tests untouched, so I'll wait for it to land and then open a fresh PR to clean out any that happen to be remaining at that point.

Thanks!

@csouth3 csouth3 deleted the remove-featuregates branch December 8, 2014 21:11
brson added a commit to brson/rust that referenced this pull request Dec 12, 2014
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed.  We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes rust-lang#19473.
brson added a commit to brson/rust that referenced this pull request Dec 13, 2014
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed.  We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes rust-lang#19473.
brson added a commit to brson/rust that referenced this pull request Dec 15, 2014
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed.  We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust.

Closes rust-lang#19473.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove #![feature()] for if_let, while_let, and tuple_indexing
4 participants