rustc: check supertraits for object safety #19539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ if the recursion is changed to iteration |
Closes #18959 Technically, this causes code that once compiled to no longer compile, but that code probably never ran. [breaking-change]
bors
added a commit
that referenced
this pull request
Dec 7, 2014
Closes #18959 Technically, this causes code that once compiled to no longer compile, but that code probably never ran. [breaking-change] ------------ Not quite sure the error message is good enough, I feel like it ought to tell you "because it inherits from non-object-safe trait Foo", so I've opened up a follow-up issue #19538
stepancheg
added a commit
to stepancheg/rust-protobuf
that referenced
this pull request
Dec 9, 2014
Something's changed in Rust: rust-lang/rust#19539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18959
Technically, this causes code that once compiled to no longer compile, but
that code probably never ran.
[breaking-change]
Not quite sure the error message is good enough, I feel like it ought to tell you "because it inherits from non-object-safe trait Foo", so I've opened up a follow-up issue #19538