documentation incorrectly described from_utf8 #19623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you!!! |
| @@ -76,7 +76,7 @@ impl FromStr for bool { | |||
| Section: Creating a string | |||
| */ | |||
|
|
|||
| /// Converts a vector to a string slice without performing any allocations. | |||
| /// Converts an array of bytes to a string slice without performing any allocations. | |||
There was a problem hiding this comment.
I believe the preferred terminology here is "slice of bytes". "Array of bytes" implies e.g. [u8, ..10].
There was a problem hiding this comment.
ahh you are correct: I missed the & because of the lifetime 😅
@rustyrazorblade mind updating please?
There was a problem hiding this comment.
Sure no problem
|
Alright, updated. |
|
Sorry, would you mind squashing? |
Docs said from_utf8 accepts a vector when it actually accepts a slice of bytes.
rustyrazorblade
force-pushed
the
patch-1
branch
from
80e5085 to
956c581
Compare
|
Sure. Rebased & squashed. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 9, 2014
Docs said from_utf8 accepts a vector when it actually accepts an array of bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs said from_utf8 accepts a vector when it actually accepts an array of bytes.