Fix ICE related to tupled arguments #19638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barosl
changed the title
barosl
force-pushed
the
typeck-tupled-arguments-ice
branch
from
3c1c1b4 to
1912c35
Compare
|
@barosl Thanks! Could you also add a regression test? See src/test/compile-fail for some examples. |
barosl
force-pushed
the
typeck-tupled-arguments-ice
branch
from
1912c35 to
1d5aabd
Compare
ghost
changed the title
When a type error occurs, check_method_argument_types() tries to provide arguments filled with ty::mk_err(). However, if a function takes the parameters as a tuple, the arguments should be converted to a tuple before being passed to check_argument_types(). Fixes rust-lang#19521.
barosl
force-pushed
the
typeck-tupled-arguments-ice
branch
from
1d5aabd to
21d12c0
Compare
bors
added a commit
that referenced
this pull request
Dec 10, 2014
When a type error occurs, `check_method_argument_types()` tries to provide arguments filled with `ty::mk_err()`. However, if a function takes the parameters as a tuple, the arguments should be converted to a tuple before passing it to `check_argument_types()`. Fixes #19521.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 28, 2025
doc: Rework generated configuration to have anchors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a type error occurs,
check_method_argument_types()tries to provide arguments filled withty::mk_err(). However, if a function takes the parameters as a tuple, the arguments should be converted to a tuple before passing it tocheck_argument_types().Fixes #19521.