Skip to content

[Windows] Change default installation directory to %SYSTEMDRIVE%\Rust. #19725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Dec 11, 2014

Change default installation directory to %SYSTEMDRIVE%\Rust.
Modify user PATH, rather than system PATH.

Modify user PATH, rather than system PATH.
@alexcrichton
Copy link
Member

Would it be possible to have the option to modify PATH of users or everyone? Also, just to make sure, is this a typical installation strategy to store into the root instead of program files?

@vadimcn
Copy link
Contributor Author

vadimcn commented Dec 11, 2014

@alexcrichton: Doing what you suggest would require conditional elevation of privileges after setup process had already been started (remember, we now do not require admin privileges at launch).
I do not see an easy way to accomplish that in InnoSetup. It may be possible through custom scripting, but I'd rather not invest much time into learning its custom scripting language, given that we'll replace InnoSetup with Windows Installer and WiX Toolset, once @brson figures out the combined installer story (I assume we do want to do this?). In WiX, this sort of thing is available out-of-the box.
Meanwhile, if adding installation directory to per-user path is not acceptable, I suggest we just revert to requiring admin privileges to install.

@brson
Copy link
Contributor

brson commented Dec 11, 2014

@vadimcn I'm am working on combined install still (probably won't have it up this week :-/) and do want to switch to msi.

@alexcrichton
Copy link
Member

@vadimcn ok thanks for explaining, I was just curious. This looks like a good idea for now, and we can expand to more functionality with an msi installer later. Thanks!

brson added a commit to brson/rust that referenced this pull request Dec 12, 2014
Change default installation directory to %SYSTEMDRIVE%\Rust.
Modify user PATH, rather than system PATH.
bors added a commit that referenced this pull request Dec 14, 2014
Change default installation directory to %SYSTEMDRIVE%\Rust.
Modify user PATH, rather than system PATH.
@bors bors closed this Dec 14, 2014
@vadimcn vadimcn deleted the inst-path branch March 1, 2015 08:05
lnicola pushed a commit to lnicola/rust that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants