rustc: Don't panic on corrupt metadata #19799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a panic where the compiler was looking at stale or old metadata. See rust-lang#19798, rust-lang#19772, rust-lang#19757, rust-lang#19744, rust-lang#19718, rust-lang#19691.
|
Isn't this just going to cause ICEs downstream when you try to read things out of the metadata? |
|
Hm, how so? This is intended to just reject all old libraries immediately instead of attempting to read their metadata. |
|
Oh, is there a check later that handles the empty slice case? SGTM then |
Closed
bors
added a commit
that referenced
this pull request
Dec 14, 2014
rustc: Don't panic on corrupt metadata Reviewed-by: huonw
brson
added a commit
to brson/rust
that referenced
this pull request
Dec 16, 2014
Fix a panic where the compiler was looking at stale or old metadata. See rust-lang#19798, rust-lang#19772, rust-lang#19757, rust-lang#19744, rust-lang#19718, rust-lang#19691.
|
This PR passed on all builders, but the windows bots are taking far too long to complete tests and buildbot needs a restart to hopefully remedy this. This PR had a few more platforms left, so I went ahead and merged it so I can go ahead and restart buildbot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a panic where the compiler was looking at stale or old metadata.
See #19798, #19772, #19757, #19744, #19718, #19691.