Make unary operators take their arguments by value #19899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lib changes LGTM. |
|
r=me modulo the nit regarding the typeck module |
|
re-r? @nikomatsakis |
added 11 commits
December 18, 2014 14:56
japaric
force-pushed
the
unops-by-value
branch
from
f2b79c3 to
9b5de39
Compare
bors
added a commit
that referenced
this pull request
Dec 19, 2014
- The following operator traits now take their argument by value: `Neg`, `Not`. This breaks all existing implementations of these traits. - The unary operation `OP a` now "desugars" to `OpTrait::op_method(a)` and consumes its argument. [breaking-change] --- r? @nikomatsakis This PR is very similar to the binops-by-value PR cc @aturon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neg,Not. This breaks all existing implementations of these traits.OP anow "desugars" toOpTrait::op_method(a)and consumes its argument.[breaking-change]
r? @nikomatsakis This PR is very similar to the binops-by-value PR
cc @aturon