Correct span in privacy error #19953
Conversation
|
|
||
| pub struct I<T> where T: Foo { //~ ERROR private type in exported type | ||
| x: T, | ||
| } |
There was a problem hiding this comment.
These two tests seem to have been deleted, was that intentional?
There was a problem hiding this comment.
Yes. They are redundant.
There was a problem hiding this comment.
Just making sure, but you've verified that there are other tests which are ensuring that struct where clauses are checked for privacy?
There was a problem hiding this comment.
No, but bounds in functions and structs (also methods, enums, etc.) are checked by the same code. I don't think separate tests are necessary. (Or, if they are necessary, tests for methods, enums, etc. are also necessary.)
There was a problem hiding this comment.
In the past the visitation code has forgotten to visit new constructs like where clauses, so could we please keep these tests? We surely can't be hurt by having a few extra tests!
There was a problem hiding this comment.
I did not delete tests for where clauses (on functions). Both <T: B> and where T: B are tested. What I deleted is tests for structs.
There was a problem hiding this comment.
Can... we please keep these? The visitation code has to specifically walk where clauses for structs and it can possibly be different than functions, and it's not really hurting us to keep them.
There was a problem hiding this comment.
It can possibly be different, but it isn't. Look, deleted tests are not decreasing any code coverage, and I checked that. But whatever. I will add tests. Thanks.
|
Added tests. |
Fix #19062.