Correct subtyping relations in pattern checking #20517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code. Previously we were creating a subtyping relation in the wrong direction. We now just unify types, which is stronger than necessary but turns out fine. Fixes rust-lang#19552. Fixes rust-lang#19997.
nikomatsakis
force-pushed
the
safety-issue-19997
branch
from
64f7081 to
dbfa054
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 5, 2015
Fixes various safety issues. r? @aturon
| impl<'a,'tcx> Foo<'a,'tcx> { | ||
| fn bother(&mut self) -> int { | ||
| self.elaborate_bounds(|this| { | ||
| // (*) Here: type of `this` is `&'f0 Foo<&'f1, '_2>`, |
There was a problem hiding this comment.
Nit: this should be &'f0 mut Foo<'f1, '_2>? (&'f1 is not a type).
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 6, 2015
Fixes various safety issues. r? @aturon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various safety issues.
r? @aturon