Implement Show for types in std::io::{buffered,util} #20910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A derived implementation would not be appropriate for the Buffered types
since the buffer is both huge (64k by default) and full of uninitialized
memory. Instead of printing the whole thing, we display how full it is.
I also altered
MultiWriter
to make it generic over Writers instead oftaking
Box<Writer>
trait objects.Box<Writer>
implementsWriter
soexisting use cases should continue to work, and this enables a more
useful Show implementation in applicable cases.
The change to
MultiWriter
may break code that uses it, but any fixesshould be easy.
[breaking-change]
r? @alexcrichton