Fixes join_multicast on Windows #20381
#21267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Thanks! I don't know much about this code at all, so r? @alexcrichton |
bors
added a commit
that referenced
this pull request
Jan 17, 2015
This patch fixes IP_ADD_MEMBERSHIP problem described here: #20381 I've tested on my ProbeR project, everything seems ok.
|
Hmm, i built rust under win 8.1 64-bit and ubuntu 14.10 64-bit, everything seems ok... How to figure out where the exeception happened? |
|
I'm not quite sure either! Let's try again and see what happens |
bors
added a commit
that referenced
this pull request
Jan 19, 2015
This patch fixes IP_ADD_MEMBERSHIP problem described here: #20381 I've tested on my ProbeR project, everything seems ok.
sagesharp
added a commit
to sagesharp/foss-heartbeat
that referenced
this pull request
Nov 4, 2016
If the script to generate the first-time contribution information misses
a style of contribution, we will get a negative delta time in the graph.
For example, right now we don't look for users who merge a contribution
as their first interaction with a project. In rust, bors is a bot that
merges tested code after a maintainer comments with a command to do so.
It first merged a commit in 2013, but it started commenting on pull
requests with the test status in 2015. Since we recorded bors start date
as the PR comment, we got a negative ramp-up time.
$ time python ../src/ghstats.py rust rust-lang
Negative delta for user bors for merger on 2013-02-02 00:46:02 ,
first contribution was on 2015-01-19 01:45:37 file rust-lang/rust/issue-54633991/comment-70437324.json
real 0m3.952s
user 0m2.956s
sys 0m0.068s
$ python -m json.tool rust-lang/rust/issue-54633991/comment-70437324.json
{
"issue_url": "https://api.github.com/repos/rust-lang/rust/issues/21267",
"created_at": "2015-01-19T01:45:37Z",
"url": "https://api.github.com/repos/rust-lang/rust/issues/comments/70437324",
"updated_at": "2015-01-19T01:45:37Z",
"id": 70437324,
"html_url": "rust-lang/rust#21267 (comment)",
"body_html": "<p><g-emoji alias=\"hourglass\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/231b.png\" ios-version=\"6.0\">\u231b\ufe0f</g-emoji> Testing commit <a href=\"https://github.com/rust-lang/rust/commit/89de6926b59136c73bf667434a53b9e05146499d\" class=\"commit-link\"><tt>89de692</tt></a> with merge <a href=\"https://github.com/rust-lang/rust/commit/bd8a43c668ba93d29e9671c0c8dc6b67428bf492\" class=\"commit-link\"><tt>bd8a43c</tt></a>...</p>",
"body": ":hourglass: Testing commit 89de692 with merge bd8a43c...",
"user": {
"type": "User",
"received_events_url": "https://api.github.com/users/bors/received_events",
"avatar_url": "https://avatars.githubusercontent.com/u/3372342?v=3",
"site_admin": false,
"gravatar_id": "",
"id": 3372342,
"html_url": "https://github.com/bors",
"gists_url": "https://api.github.com/users/bors/gists{/gist_id}",
"repos_url": "https://api.github.com/users/bors/repos",
"followers_url": "https://api.github.com/users/bors/followers",
"url": "https://api.github.com/users/bors",
"starred_url": "https://api.github.com/users/bors/starred{/owner}{/repo}",
"events_url": "https://api.github.com/users/bors/events{/privacy}",
"following_url": "https://api.github.com/users/bors/following{/other_user}",
"organizations_url": "https://api.github.com/users/bors/orgs",
"subscriptions_url": "https://api.github.com/users/bors/subscriptions",
"login": "bors"
},
"body_text": "\u231b\ufe0f Testing commit 89de692 with merge bd8a43c..."
}
Signed-off-by: Sarah Sharp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes IP_ADD_MEMBERSHIP problem described here: #20381
I've tested on my ProbeR project, everything seems ok.