-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Spellfix for Debug trait #21586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spellfix for Debug trait #21586
Conversation
Spellfix for `Debug` trait documentation. Change "most all types should implement this" to "all types should implement this". Same fix for deprecated `Show` trait.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
Hmm, when I read this, I thought it was intentional, with ‘most all’ informally meaning ‘almost all’. I think that this should probably be changed to ‘almost all’ instead of just ‘all’, unless we are recommending that literally every type should implement |
Thanks for your comment. I assumed that the "most" was a forgotten word. English language is quite interesting, but I would prefer if the docs would use a form I understand. :grin I found a RFC that clarifies what types should implement
Now it should be clear that "all" is correct, or isn't it? By the way I think it would be a great thing if the important parts of the RFC would be part of the docs. |
Spellfix for `Debug` trait documentation. Change "most all types should implement this" to "all types should implement this". Same fix for deprecated `Show` trait.
Spellfix for `Debug` trait documentation. Change "most all types should implement this" to "all types should implement this". Same fix for deprecated `Show` trait.
Spellfix for
Debug
trait documentation. Change "most all types should implement this" to "all types should implement this". Same fix for deprecatedShow
trait.