Various cleanup #21626
Merged
Various cleanup #21626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
| /// The type of the iterator used by with_path. | ||
| pub type PathElems<'a, 'b> = iter::Chain<Values<'a, PathElem>, LinkedPath<'b>>; | ||
| pub type PathElems<'a, 'b> = iter::Chain<iter::Cloned<slice::Iter<'a, PathElem>>, LinkedPath<'b>>; |
Ms2ger
force-pushed
the
various-cleanup
branch
from
408a21a to
d87ee7b
Compare
barosl
added a commit
to barosl/rust
that referenced
this pull request
Jan 27, 2015
|
This caused a test failure on the rollup http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3333/steps/test/logs/stdio |
| s.identifier.name == t.identifier.name && | ||
| // FIXME #7743: ident -> name problems in lifetime comparison? | ||
| // can types contain idents? | ||
| s.parameters != t.parameters |
There was a problem hiding this comment.
Oops, I didn't notice the inverted condition here, should be ==. Good thing we have tests.
|
You also have an unused |
This matches contemporary Rust style.
Ms2ger
force-pushed
the
various-cleanup
branch
from
d87ee7b to
cbd9dbe
Compare
Ms2ger
force-pushed
the
various-cleanup
branch
from
cbd9dbe to
7aa2735
Compare
|
Both fixed, sorry about that. |
|
@bors r+ 7aa2735 rollup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.