Implement Thread::park_timeout #21788
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Woops, I am noticing botched docs. Fixed |
| pub fn park_timeout(dur: Duration) { | ||
| let thread = Thread::current(); | ||
| let mut guard = thread.inner.lock.lock().unwrap(); | ||
| let (mut guard, _) = thread.inner.cvar.wait_timeout(guard, dur).unwrap(); |
There was a problem hiding this comment.
Shouldn't this be wrapped in while !*guard like the loop above? Otherwise this will block no matter what even if a previous unpark was seen.
There was a problem hiding this comment.
Yes, you are correct. :( I have failed.
|
Could you also add a test for this? A few simple smoke tests should be fine, but largely just something that calls the functions. |
|
Done |
The implementation is similar to `Thread::park`
The implementation is similar to
Thread::park