add naivest entry API to VecMap #21882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ e6ef2da |
|
🙀 You have the wrong number! Please try again with |
|
@bors r=huonw 88449 |
| @@ -13,6 +13,8 @@ | |||
|
|
|||
| #![allow(missing_docs)] | |||
|
|
|||
| pub use self::Entry::*; | |||
There was a problem hiding this comment.
Hmm, I basically was copy-pasting from BTreeMap, I didn't even notice the pub.
I'm going to refactor this all in my next PR anyway.
There was a problem hiding this comment.
Why not get rid of it now? One fewer thing to remember
There was a problem hiding this comment.
Won't be home to fix this for a while.
|
⌛ Testing commit 88449a8 with merge 7818e90... |
|
💔 Test failed - auto-win-64-opt |
|
@bors: retry |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 4, 2015
Building over night, posting for review now. Presumably not much should need change. I consider this necessary to move forward with a proper stabilization of the API. r? @huonw
|
⌛ Testing commit 88449a8 with merge 82c7347... |
|
@bors: retry |
|
(sorry about the weird activity, try to kick homu) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building over night, posting for review now. Presumably not much should need change.
I consider this necessary to move forward with a proper stabilization of the API.
r? @huonw