compatibility issues in configure and make tidy

[semarie]

the sed option --in-place (or -i) is a GNU extension, and it is not
portable to BSD system (openbsd and freebsd checked).

use an alternate construction in order to keep the semantic.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[semarie]

I add a patch for a compatibility issue with find, use for make tidy

[alexcrichton]

Unfortunately it looks like this may not work on osx:

$ find . -type f -perm /a+x
find: -perm: /a+x: illegal mode string

[semarie]

I have revert the change about find.
It seems that the find utility under macos isn't the GNU one (and not the same as under openbsd).

I have check the form -perm +mode against POSIX, and it isn't a POSIX form. So the problem of portability remains...

[semarie]

osx should be ok (I have checked against the manual page on the apple website)
all options are now POSIX (if I miss any).

[alexcrichton]

@bors: r+ 30b8078

Thanks!

[bors]

⌛ Testing commit 30b8078 with merge e95e3a8...

[bors]

💔 Test failed - auto-win-32-opt

[semarie]

hum... I am not sure about the error under Windows. Maybe the shell miss interpret the ! char ? (it would need \!)

@alexcrichton what is the build env under windows ? cygwin I think ? I would like to test locally, instead of blindly provide a patch...

[semarie]

I am note sure that the failed is related to my patch, or how it is related to it...

Next, the failed as captured by log:

check: binaries
Binaries checked into src:
/c/bot/slave/auto-win-32-opt/build/src/test/pretty/issue-4264.pp
/c/bot/slave/auto-win-32-opt/build/mk/tests.mk:256: recipe for target 'tidy-binaries' failed
make: *** [tidy-binaries] Error 123

The line Binaries checked into src: come from src/etc/check-binaries.py, which is after the changed find command (it is the last command in the pipe, called with xargs). So the changed find command was run successfully.

The error is due to the file src/test/pretty/issue-4264.pp, which match the find.
So either:

• the file src/test/pretty/issue-4264.pp was executable for this build only (but why ?)
• the file src/test/pretty/issue-4264.pp is executable on this host, but the previous find doesn't match it (but why ?)
• the find match differently than before (but not under linux nor mac [the others buildbot test that are ok])

@alexcrichton any clue ?

[alexcrichton]

Hm I've seen this warning about that file being executable before, but I'm not quite sure why it's cropping up. Our windows bots currently run inside of MSYS2 with both a 32 and 64 bit shell (using mingw-w64 as a compiler).

[semarie]

@alexcrichton I have no way to easily check the make tidy problem on windows host.
What do you think ? Should I just revert the patch about make tidy for now ?

[alexcrichton]

I may be best to revert the changes to find for now.

[semarie]

I have rebased to more recent HEAD, and removed the three lasts patchs (first try with find, a revert, and another try...)

[alexcrichton]

@bors: r+ 04b7976

[bors]

⌛ Testing commit 04b7976 with merge 95b228a...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt