Skip to content

reference.md: Byte string literals start with a 'b' #22072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2015

Conversation

geofft
Copy link
Contributor

@geofft geofft commented Feb 8, 2015

This was correct in the EBNF, but not in the prose (which seems to have
been copied-and-pasted from regular string literals).

This was correct in the EBNF, but not in the prose (which seems to have
been copied-and-pasted from regular string literals).
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@kmcallister
Copy link
Contributor

@bors r+ bb49195 rollup

kmcallister added a commit to kmcallister/rust that referenced this pull request Feb 8, 2015
…mcallister

This was correct in the EBNF, but not in the prose (which seems to have
been copied-and-pasted from regular string literals).
@bors
Copy link
Collaborator

bors commented Feb 9, 2015

⌛ Testing commit bb49195 with merge aa43eec...

bors added a commit that referenced this pull request Feb 9, 2015
This was correct in the EBNF, but not in the prose (which seems to have
been copied-and-pasted from regular string literals).
@bors
Copy link
Collaborator

bors commented Feb 9, 2015

💔 Test failed - auto-win-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 10, 2015
…mcallister

This was correct in the EBNF, but not in the prose (which seems to have
been copied-and-pasted from regular string literals).
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Feb 10, 2015
This was correct in the EBNF, but not in the prose (which seems to have
been copied-and-pasted from regular string literals).
@bors bors merged commit bb49195 into rust-lang:master Feb 10, 2015
@geofft geofft deleted the doc-byte-string-literal branch May 24, 2015 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants