-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make docs fallback font 'serif', rather than 'sans-serif' #22097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
ce6f81c
to
840be23
Compare
Why remove Helvetica, Arial and friends? |
@nagisa because they're sans-serif fonts. If "Source Serif Pro" cannot load, we should load another serif font, not a sans-serif one. |
I agree with this conceptually, but the gap between "Source Serif Pro" and |
If we were to remove the sans-serif fallbacks in favour of serif fonts, I think a Georgia-based stack would work pretty well. It supposedly has good compatibility and looks somewhat similar to Source Serif Pro. font-family: "Source Serif Pro", Georgia, Times, Times New Roman, serif; |
840be23
to
643600c
Compare
Good call! Just updated it to the Georgia stack as the fallback. |
643600c
to
45f6672
Compare
…abnik The fallback font for a serif font should also be serif, not sans serif.
The fallback font for a serif font should also be serif, not sans serif.
The fallback font for a serif font should also be serif, not sans serif.