Move rustc docs to the book #22126
Move rustc docs to the book #22126
Conversation
|
Hm, general note, the trpl directory is getting quite busy: https://github.com/steveklabnik/rust/tree/gh21281/src/doc/trpl Is it possible to e.g. put these into an |
|
Maybe. It ends up making more nested URLs, and I don't remember if Rustbook supports that or not. |
|
|
||
| fn bar() { | ||
| let x: @mut int = @mut 3; | ||
| let y: @int = @3; |
There was a problem hiding this comment.
Wow, this is a blast from the past.
There was a problem hiding this comment.
heh, yeah, I was solely looking to move stuff, not to update it.
|
Looks good to me. I wholeheartedly approve of putting these in the book. It's great to have a peek behind the curtain even if the only takeaway is "o_O". In particular I think the borrowchecker docs are important if you want a precise understanding of Rust semantics. It's more conceptual than a purely internal thing. It might even be a good starting point for an "advanced borrowchecker" chapter in Part III. (Actually, what I really would like to do is implement a toy borrowchecker for a subset of Rust, as a way to solidify my own understanding, and produce a blog series / literate code repo / something along the way. But who knows when I'll have time to do that...) btw, I agree with the choice to keep |
|
The reference to |
|
Might want to add an informative sidebar somewhere on the subject of "What the hell does 'skolemize' mean?" |
|
Hmm, I don't know how I feel about having these outside the compiler source code. The whole idea is that when browsing code in directory |
|
(They are already somewhat dated and ever at risk for being out of date, putting them in "the book" makes that even more likely it seems to me.) |
In that case maybe they should be named |
This is super black magic internals at the moment, but having it somewhere semi-public seems good. The current versions weren't being rendered, and they'll be useful for some people. Fixes rust-lang#21281
steveklabnik
force-pushed
the
gh21281
branch
from
bf3df5e to
fc3bb17
Compare
|
Good idea, @kmcallister . Done. What do you think, @nikomatsakis ? |
|
Should also help them stand out in the directory listing. |
|
@bors r+ fc3bb17 |
|
seems good to me! |
|
⌛ Testing commit fc3bb17 with merge e89dbed... |
|
💔 Test failed - auto-mac-64-opt |
steveklabnik
force-pushed
the
gh21281
branch
from
fc3bb17 to
14a0e4a
Compare
|
Oops, forgot to remove a few |
|
@bors: r=nikomatsakis 14a0e4a |
steveklabnik
force-pushed
the
gh21281
branch
from
14a0e4a to
ad2efdc
Compare
|
⌛ Testing commit ad2efdc with merge b98a476... |
|
💔 Test failed - auto-win-32-opt |
|
@bors: retry |
|
⌛ Testing commit ad2efdc with merge 3f906bf... |
|
💔 Test failed - auto-mac-64-opt |
|
⌛ Testing commit bdc730e with merge 3bf0df7... |
|
💔 Test failed - auto-win-64-nopt-t |
|
@bors: retry |
This is super black magic internals at the moment, but having it somewhere semi-public seems good. The current versions weren't being rendered, and they'll be useful for some people. Fixes #21281 r? @nikomatsakis @kmcallister
|
⌛ Testing commit bdc730e with merge b6d91a2... |
This is super black magic internals at the moment, but having it
somewhere semi-public seems good. The current versions weren't being
rendered, and they'll be useful for some people.
Fixes #21281
r? @nikomatsakis @kmcallister