Fix ICE when compiling "extern" rust functions #22160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the function comment already says, the types generated in the foreign_signture function don't necessarily match the types used for a corresponding rust function. Therefore we can't just use these types to guide the translation of the wrapper function that bridges between the external ABI and the rust ABI. Instead, we can query LLVM about the types used in the rust function and use those to generate an appropriate wrapper. Fixes rust-lang#21454
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ 61db |
bors
added a commit
that referenced
this pull request
Feb 11, 2015
As the function comment already says, the types generated in the foreign_signture function don't necessarily match the types used for a corresponding rust function. Therefore we can't just use these types to guide the translation of the wrapper function that bridges between the external ABI and the rust ABI. Instead, we can query LLVM about the types used in the rust function and use those to generate an appropriate wrapper. Fixes #21454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the function comment already says, the types generated in the
foreign_signture function don't necessarily match the types used for a
corresponding rust function. Therefore we can't just use these types to
guide the translation of the wrapper function that bridges between the
external ABI and the rust ABI. Instead, we can query LLVM about the
types used in the rust function and use those to generate an appropriate
wrapper.
Fixes #21454