Unsafe lint will also check for unsafe functions, traits, and implementations #22542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Looks great. Could you add a test for an impl Foo {
unsafe fn method(&self) {}
} |
| Allow, | ||
| "usage of an `unsafe` block" | ||
| "usage of an `unsafe` code" |
There was a problem hiding this comment.
nit: drop the article an
There was a problem hiding this comment.
oops, totally missed that, thanks for the catch!
Checks include declaration/implementation of unsafe functions, traits, and methods. This allows warning or forbidding all uses of unsafe code, whereas previously only unsafe blocks were caught by the lint. The lint has been renamed from `unsafe-blocks` to `unsafe-code` to reflect its new purpose. This is a minor [breaking-change] Closes #22430
|
@huonw I added tests for (both declaring and implementing) unsafe methods of traits. My previous implementation of the lint didn't catch these, so I refactored the code to catch them as well! |
|
@bors r+ be0d Thanks! |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 21, 2015
This allows warning or forbidding all uses of unsafe code, whereas previously only unsafe blocks were caught by the lint. The lint has been renamed from `unsafe-blocks` to `unsafe-code` to reflect its new purpose. This is a minor [breaking-change] Closes rust-lang#22430
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 21, 2015
|
Needs Manishearth@bf13792 to work. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 21, 2015
This allows warning or forbidding all uses of unsafe code, whereas previously only unsafe blocks were caught by the lint. The lint has been renamed from `unsafe-blocks` to `unsafe-code` to reflect its new purpose. This is a minor [breaking-change] Closes rust-lang#22430
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 21, 2015
|
Thank you for the fix @Manishearth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows warning or forbidding all uses of unsafe code, whereas
previously only unsafe blocks were caught by the lint.
The lint has been renamed from
unsafe-blockstounsafe-codetoreflect its new purpose.
This is a minor [breaking-change]
Closes #22430