Skip to content

try to reduce bajillion test warnings #22567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2015
Merged

try to reduce bajillion test warnings #22567

merged 2 commits into from
Feb 22, 2015

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Feb 20, 2015

  • Adds features and allows
  • Removes unused muts, unused imports, dead code
  • Migrates some deprecated code to new io/env
  • Changes std::num::uint/int to be re-exports of std::num::usize/isize

libcollections, liballoc, and libcoretest no longer warn during testing.

libstd warns much less, though there's some dangly bits that weren't obvious fixes. In particular, how to only supress deprecated warnings in specific submodules of std.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@Gankra
Copy link
Contributor Author

Gankra commented Feb 20, 2015

Ah dang some stuff snuck in while I was doing this. Will handle conflicts in the morning.

@alexcrichton
Copy link
Member

r=me whenever this is ready

@Gankra
Copy link
Contributor Author

Gankra commented Feb 20, 2015

Currently removing all the []'s, because I hate myself, apparently.

@Gankra Gankra force-pushed the unstable branch 2 times, most recently from 8b2ed05 to bee14ae Compare February 20, 2015 22:01
@Gankra
Copy link
Contributor Author

Gankra commented Feb 20, 2015

Rolled back a bunch of my work to not conflict with other PRs.

@bors r=alexcrichton bee14ae

@Gankra
Copy link
Contributor Author

Gankra commented Feb 20, 2015

@bors r-

bah

bugs bugs bugs

@Gankra
Copy link
Contributor Author

Gankra commented Feb 21, 2015

@bors r=alexcrichton ac7d964

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 21, 2015
 * Adds features and allows
* Removes unused muts, unused imports, dead code
* Migrates some deprecated code to new io/env
* Changes std::num::uint/int to be re-exports of std::num::usize/isize

libcollections, liballoc, and libcoretest no longer warn during testing.

libstd warns much less, though there's some dangly bits that weren't obvious fixes. In particular, how to only supress deprecated warnings in specific submodules of std.
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 21, 2015
 * Adds features and allows
* Removes unused muts, unused imports, dead code
* Migrates some deprecated code to new io/env
* Changes std::num::uint/int to be re-exports of std::num::usize/isize

libcollections, liballoc, and libcoretest no longer warn during testing.

libstd warns much less, though there's some dangly bits that weren't obvious fixes. In particular, how to only supress deprecated warnings in specific submodules of std.
@huonw huonw merged commit ac7d964 into rust-lang:master Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants