Skip to content

Fix thread documentation #22604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2015
Merged

Fix thread documentation #22604

merged 1 commit into from
Feb 24, 2015

Conversation

aochagavia
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aochagavia
Copy link
Contributor Author

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned aturon Feb 20, 2015
@aturon
Copy link
Member

aturon commented Feb 20, 2015

This fix isn't quite right -- the thread isn't detached by default, it only becomes detached if you discard the join handle. Maybe just "thread"?

(The paragraph below it could also be clarified to explain this.)

@aochagavia
Copy link
Contributor Author

@aturon updated the PR with your suggestions! Let me know if something else needs to be changed.

@alexcrichton
Copy link
Member

@bors: r+ 189409f rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2015
@bors bors merged commit 189409f into rust-lang:master Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants