Skip to content

std::prelude: code consistency nits #22687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2015
Merged

std::prelude: code consistency nits #22687

merged 1 commit into from
Feb 24, 2015

Conversation

tshepang
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

#[doc(no_inline)] pub use iter::ExactSizeIterator;
#[stable(feature = "rust1", since = "1.0.0")]
#[doc(no_inline)] pub use iter::{Iterator, IteratorExt, Extend};
#[doc(no_inline)] pub use iter::{Iterator, IteratorExt, Extend, ExactSizeIterator};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done to keep the line under 80 characters, can you leave as it was before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though it was fine since the guidelines allow 100 characters

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but it is more important to stick within the existing style already present within a file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done

@alexcrichton
Copy link
Member

@bors: r+ bb0e0a9

@alexcrichton
Copy link
Member

@bors: rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2015
@bors bors merged commit bb0e0a9 into rust-lang:master Feb 24, 2015
@tshepang tshepang deleted the prelude-nits branch May 31, 2015 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants