Slightly less mini rollup #23200
Merged
Slightly less mini rollup #23200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was having trouble figuring out which functions had tests and which didn't. This commit is just moving tests around and does not change anything.
* "let met text" was previously of &String type. Now it is of &str type. * Update the slicing syntax. Both &text[] and text.slice_from() evaluate to a &str. * We were passing a u32 to expr_usize. Call expr_u32 instead.
…eklabnik * "let mut text" was previously of &String type. Now it is of &str type. * Update the slicing syntax. Both &text[] and text.slice_from() evaluate to a &str. * We were passing a u32 to expr_usize. Call expr_u32 instead. r? @steveklabnik Fixes rust-lang#23166
Building on rust-lang#22076, I've added some tests for stable methods in f32 and f64 that didn't have any before. Please let me know if there are any improvements I can make, and I am happy to make them! 📬
…abnik I had to fix up some PRs: * rust-lang#22976 * rust-lang#22945 * rust-lang#22845
Needed so that rust-lang#21824 can land
The docs currently define `array_expr`s as:
array_expr : '[' \"mut\" ? vec_elems? ']' ;
array_elems : [expr [',' expr]*] | [expr ',' \"..\" expr] ;
`vec_elems` is not defined anywhere else so it is probably a typo for `array_elems`.
|
@bors: r+ p=20 |
bors
added a commit
that referenced
this pull request
Mar 8, 2015
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry |
|
@bors: r+ |
bors
added a commit
that referenced
this pull request
Mar 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.