rustdoc: Fix ICE with cross-crate default impls #23328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
I am so sorry to ask this, but can this ICE be captured in a test case? |
|
r=me |
This adds a special code path for impls which are listed as default impls to ensure that they're loaded correctly.
alexcrichton
force-pushed
the
rustdoc-default-impl
branch
from
2e0123b to
4e25765
Compare
|
@bors: r=brson |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 13, 2015
…r=brson This adds a special code path for impls which are listed as default impls to ensure that they're loaded correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a special code path for impls which are listed as default impls to
ensure that they're loaded correctly.