Add functions for converting IP to int and back #24618
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
This impl won’t work for Windows. |
|
What about just providing an iterator over bytes? That will work seamlessly for both IPv4/IPv6 and seems to be what other libraries do (eg. .net) |
|
Could you expand on the rationale for this a bit as well? For example this should be possible via the existing constructors/ |
|
@alexcrichton I do not have anything very concrete, this looks like a bad idea in hindsight. I will work on using the octets to do this. |
|
Ok, thanks for the PR anyway @achanda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still haven't figured out how to do this for IPv6 properly