derive: Give access to field attributes in ext::deriving #25027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -378,7 +380,7 @@ impl<'a> TraitDef<'a> { | |||
| pub fn expand(&self, | |||
| cx: &mut ExtCtxt, | |||
| mitem: &ast::MetaItem, | |||
| item: &ast::Item, | |||
| item: &'a ast::Item, | |||
|
r=me with the whitespace fix. Also, tidy failed on travis. |
|
@bors: r=huonw |
|
📌 Commit 5892b40 has been approved by |
bors
added a commit
that referenced
this pull request
May 2, 2015
Adds an `attrs` field to `FieldInfo` which lets one check the attributes on a field whilst expanding. This lets deriving plugins be more robust, for example providing the ability to "ignore" a field for the purpose of deriving, or perhaps handle the field a different way. r? @huonw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
attrsfield toFieldInfowhich lets one check the attributes ona field whilst expanding.
This lets deriving plugins be more robust, for example providing the ability to
"ignore" a field for the purpose of deriving, or perhaps handle the field a
different way.
r? @huonw