Skip to content

Update AUTHORS.txt #25253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2015
Merged

Update AUTHORS.txt #25253

merged 2 commits into from
May 13, 2015

Conversation

robertfoss
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

Manishearth
Manishearth reviewed May 10, 2015
View reviewed changes
AUTHORS.txt
@@ -709,6 +709,7 @@ Rob Hoelz <[email protected]>
Robert Buonpastore <[email protected]>
Robert Clipsham <[email protected]>
Robert Gawdzik <[email protected]>
RObert Foss <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Accidental capital O?

@alexcrichton
Copy link
Member

r? @brson

Also cc #

@rust-highfive rust-highfive assigned brson and unassigned huonw May 10, 2015
@alexcrichton
Copy link
Member

er, cc #25196

@brson
Copy link
Contributor

brson commented May 12, 2015

@bors r+ rollup. I'll cherry-pick this into beta too.

@bors
Copy link
Collaborator

bors commented May 12, 2015

📌 Commit 90bd31b has been approved by brson

@brson brson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 12, 2015
@brson
Copy link
Contributor

brson commented May 12, 2015

Skipped straight to beta-accepted.

@bors
Copy link
Collaborator

bors commented May 12, 2015

⌛ Testing commit 90bd31b with merge de2e765...

@bors
Copy link
Collaborator

bors commented May 12, 2015

💔 Test failed - auto-linux-64-opt

@alexcrichton
Copy link
Member

@bors: retry

bors added a commit that referenced this pull request May 13, 2015
@bors
Auto merge of #25253 - robertfoss:master, r=brson
67433c1
@bors
Copy link
Collaborator

bors commented May 13, 2015

⌛ Testing commit 90bd31b with merge 67433c1...

@bors
Copy link
Collaborator

bors commented May 13, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit 90bd31b into rust-lang:master May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@robertfoss @rust-highfive @alexcrichton @brson @bors @Manishearth @huonw