Return an iterator from enum_variant_ids. #25926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| fn next(&mut self) -> Option<ast::DefId> { | ||
| self.iter.next().map(|p| translated_def_id(self.cdata, p)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Is it possible to use a better size_hint? It's important since the iterator is collected when used.
|
Done |
|
Thanks! I think the answer to my question should have been “no”, unfortunately. The underlying iterators have no size information and maybe won't have since it's kind of a filtering operation. Thanks anyway and this sets it up to improve if the adapted iterator improves, though. |
bors
added a commit
that referenced
this pull request
Jun 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.