Skip to content

Clarified naming convention for Cargo #26032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2015
Merged

Conversation

achiwhane
Copy link
Contributor

Added a sentence that tells the user that using main.rs and/or lib.rs is required for Cargo.

Added a sentence that tells the user that using main.rs and/or lib.rs is required for Cargo.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -33,7 +33,8 @@ $ mv main.rs src/main.rs
```

Note that since we're creating an executable, we used `main.rs`. If we
want to make a library instead, we should use `lib.rs`.
want to make a library instead, we should use `lib.rs`. This convention is required
for Cargo to successfully compile our projects.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the thing is, it's not actually required. It's just convention. You can override the convention if you want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. I'm new to Rust so sorry for the misunderstanding. I've added that and committed the change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's totally okay! :)

@steveklabnik
Copy link
Member

Thank you so much! One or two nits.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 5, 2015

📌 Commit ac3301e has been approved by steveklabnik

@steveklabnik
Copy link
Member

Looks great! Now we wait on bors.

Thanks for the patch!

bors added a commit that referenced this pull request Jun 5, 2015
Added a sentence that tells the user that using main.rs and/or lib.rs is required for Cargo.
@bors
Copy link
Collaborator

bors commented Jun 5, 2015

⌛ Testing commit ac3301e with merge 0b0c89e...

@bors
Copy link
Collaborator

bors commented Jun 5, 2015

💔 Test failed - auto-linux-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Jun 5, 2015 at 4:02 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/5196


Reply to this email directly or view it on GitHub
#26032 (comment).

@bors
Copy link
Collaborator

bors commented Jun 6, 2015

@bors bors merged commit ac3301e into rust-lang:master Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants