book: point to reference section, which defines traits #26116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -19,7 +19,8 @@ impl Circle { | |||
|
|
|||
| [methodsyntax]: method-syntax.html | |||
|
|
|||
| Traits are similar, except that we define a trait with just the method | |||
| [Traits](../reference.html#traits) are similar, | |||
There was a problem hiding this comment.
We don't generally link to the reference from the book, or at least, not that I'm aware of. So, while I don't think this is wrong, but it is a bit unusual.
There was a problem hiding this comment.
Alternatively, how/where would you insert the definition of trait in this chapter?
There was a problem hiding this comment.
This is the traits chapter, so it should explain it.
There was a problem hiding this comment.
I mean where in the chapter should it be defined? Maybe before the first paragraph?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.