Skip to content

disabling socking timing tests because openbsd/bitrig get/set are not… #26155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2015
Merged

disabling socking timing tests because openbsd/bitrig get/set are not… #26155

merged 1 commit into from
Jun 11, 2015

Conversation

dhuseby
Copy link

@dhuseby dhuseby commented Jun 9, 2015

… congruent due to rounding errors

@semarie this affected both openbsd and bitrig. it seems the correct solution is to switch to fixed point arithmetic in the timeout code, the same as freebsd.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ c181819a8068d99f0a725444c76e913677e051fc

@dhuseby
Copy link
Author

dhuseby commented Jun 11, 2015

rebased to master

@alexcrichton
Copy link
Member

@bors: r+ 4a2d4d3

bors added a commit that referenced this pull request Jun 11, 2015
… congruent due to rounding errors

@semarie this affected both openbsd and bitrig.  it seems the correct solution is to switch to fixed point arithmetic in the timeout code, the same as freebsd.
@bors
Copy link
Collaborator

bors commented Jun 11, 2015

⌛ Testing commit 4a2d4d3 with merge cf0edd0...

@bors bors merged commit 4a2d4d3 into rust-lang:master Jun 11, 2015
@dhuseby dhuseby deleted the fixing_bitrig_net_tests branch June 11, 2015 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants