Skip to content

Don't link to specific versions of rust in the book. #26229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2015
Merged

Don't link to specific versions of rust in the book. #26229

merged 1 commit into from
Jun 12, 2015

Conversation

Stebalien
Copy link
Contributor

They're forever doomed to be out-of-date. Also, don't assume the user is
installing a particular version.

r? @steveklabnik

@Stebalien
Don't link to specific versions of rust in the book.
e2e292c 
They're forever doomed to be out-of-date. Also, don't assume the user is
installing a particular version.
Stebalien
Stebalien reviewed Jun 11, 2015
View reviewed changes
src/doc/trpl/installing-rust.md

```bash
rustc 1.0.0 (a59de37e9 2015-05-13) (built 2015-05-14)
rustc 1.0.0 (a59de37e9 2015-05-13)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, technically this isn't correct for 1.0 but it is for 1.1+.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 11, 2015

📌 Commit e2e292c has been approved by steveklabnik

@Manishearth Manishearth mentioned this pull request Jun 12, 2015
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 12, 2015
@Manishearth
Rollup merge of rust-lang#26229 - Stebalien:versionless-book, r=steve…
8f841b2 
…klabnik

They're forever doomed to be out-of-date. Also, don't assume the user is
installing a particular version.

r? @steveklabnik
bors added a commit that referenced this pull request Jun 12, 2015
@bors
Auto merge of #26238 - Manishearth:rollup, r=Manishearth
a2f2a64 
- Successful merges: #24495, #26229, #26231
- Failed merges:
@bors bors merged commit e2e292c into rust-lang:master Jun 12, 2015
@brson brson added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Jun 19, 2015
@brson
Copy link
Contributor

brson commented Jun 19, 2015

cherry-picking this to 1.1 because the bad instructions bother me

@brson
Copy link
Contributor

brson commented Jun 19, 2015

Actually, nevermind. It doesn't apply cleanly.

@brson brson added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jun 19, 2015
@brson
Copy link
Contributor

brson commented Jun 19, 2015

@steveklabnik is going to do the cherry-pick

@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 19, 2015
@steveklabnik
Copy link
Member

#26440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stebalien @steveklabnik @bors @brson