Remove old runtime panic test #26249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has an interesting history, because of fail -> panic. It was originally called extern-fail.rs: https://github.com/rust-lang/rust/commits/master/src/test/run-fail/extern-fail.rs It lived for a while, but was disabled in August 2013: rust-lang@ce95b01 As you can see, that failure was not specific to this test, however, this code does stuff with the runtime, which was removed. Given that it hasn't even been able to compile in a long time, we should just remove it.
bors
added a commit
that referenced
this pull request
Jun 13, 2015
This test has an interesting history, because of fail -> panic. It was originally called extern-fail.rs: https://github.com/rust-lang/rust/commits/master/src/test/run-fail/extern-fail.rs It lived for a while, but was disabled in August 2013: ce95b01 As you can see, that failure was not specific to this test, however, this code does stuff with the runtime, which was removed. Given that it hasn't even been able to compile in a long time, we should just remove it. r? @brson
|
💔 Test failed - auto-win-gnu-64-nopt-t |
|
@bors: retry On Fri, Jun 12, 2015 at 10:54 PM, bors [email protected] wrote:
|
bors
added a commit
that referenced
this pull request
Jun 13, 2015
This test has an interesting history, because of fail -> panic. It was originally called extern-fail.rs: https://github.com/rust-lang/rust/commits/master/src/test/run-fail/extern-fail.rs It lived for a while, but was disabled in August 2013: ce95b01 As you can see, that failure was not specific to this test, however, this code does stuff with the runtime, which was removed. Given that it hasn't even been able to compile in a long time, we should just remove it. r? @brson
|
⌛ Testing commit 5a5499b with merge 3250660... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has an interesting history, because of fail -> panic. It was
originally called extern-fail.rs:
https://github.com/rust-lang/rust/commits/master/src/test/run-fail/extern-fail.rs
It lived for a while, but was disabled in August 2013:
ce95b01
As you can see, that failure was not specific to this test, however,
this code does stuff with the runtime, which was removed. Given that
it hasn't even been able to compile in a long time, we should just
remove it.
r? @brson