-
Notifications
You must be signed in to change notification settings - Fork 13.3k
improve escape_unicode example #26260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks better without all that wasted whitespace
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
/// 6 | ||
/// 4 | ||
/// } | ||
/// \u{2764} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did this change somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it a print!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe separating them would make what's happening here clearer?
For a second there I thought it printed the whole line at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddyb As in print!
is not distinct enough from println!
?
@bors: r+ rollup |
📌 Commit 2c08654 has been approved by |
No description provided.