Skip to content

improve escape_unicode example #26260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2015
Merged

improve escape_unicode example #26260

merged 2 commits into from
Jun 13, 2015

Conversation

tshepang
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

/// 6
/// 4
/// }
/// \u{2764}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this change somehow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it a print!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe separating them would make what's happening here clearer?
For a second there I thought it printed the whole line at once.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddyb As in print! is not distinct enough from println!?

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 12, 2015

📌 Commit 2c08654 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 13, 2015
bors added a commit that referenced this pull request Jun 13, 2015
@bors bors merged commit 2c08654 into rust-lang:master Jun 13, 2015
@tshepang tshepang deleted the improve-example branch June 14, 2015 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants