Update example in "Rust Inside Other Languages" #26311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,10 +66,15 @@ threads = [] | |||
| 5_000_000.times do | |||
| count += 1 | |||
| end | |||
|
|
|||
| Thread.current[:output] = count | |||
There was a problem hiding this comment.
hmmm, this changes it from the rust significantly, doesn't it?
There was a problem hiding this comment.
Probably, my ruby is not very up to par. Would it be better to just return count from the threads and then collect the values using t.value?
Use result of the computation to prevent the compiler from optimising too much. Change `_x` to `x` and therefore remove the paragraph about the underscore. Fixes rust-lang#25855.
|
Updated. |
|
@bors: r+ |
|
📌 Commit 3e7ab1b has been approved by |
|
Thanks! :) |
|
⌛ Testing commit 3e7ab1b with merge 8b31bd3... |
|
⛄ The build was interrupted to prioritize another pull request. |
bors
added a commit
that referenced
this pull request
Jun 15, 2015
Use result of the computation to prevent the compiler from optimising too much. Change `_x` to `x` and therefore remove the paragraph about the underscore. Fixes #25855. r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use result of the computation to prevent the compiler from optimising
too much. Change
_xtoxand therefore remove the paragraph aboutthe underscore.
Fixes #25855.
r? @steveklabnik