Add E0092, E0093, E0094, E0101, E0117, E0119, E0195, E0207 and E0211 error explanation #26651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| struct Foo; | ||
|
|
||
| impl Trait for Foo { | ||
| fn t<'a,'b>(x: &'a str, y: &'b str) { // error: lifetime parameters |
There was a problem hiding this comment.
maybe the comment could go to the next line (or get deindented on the second line) instead of wrapping and spanning 4 whole lines?
There was a problem hiding this comment.
I saw it like this in other error explanations. So I don't mind. I'll wait for other opinions before changing it, we'll see what people say.
There was a problem hiding this comment.
I prefer having it on the next line
GuillaumeGomez
changed the title
GuillaumeGomez
changed the title
GuillaumeGomez
changed the title
| @@ -1022,6 +1022,119 @@ type Foo<A> = Box<A>; // ok! | |||
| ``` | |||
| "##, | |||
|
|
|||
| E0092: r##" | |||
| You tried to call an undefined atomic operation function. | |||
|
@Manishearth: Updated! Do you see anything else ? |
| } | ||
| ``` | ||
|
|
||
| The 'b lifetime constraints for `t` implementation does not match the |
There was a problem hiding this comment.
- Backticks around
'b - "The lifetime constraint
'bfor the implementation oft()does not match the trait declaration" - replacing
twithmethodmight be better
|
@bors r+ rollup |
|
📌 Commit 5aeecd2 has been approved by |
|
@bors r- |
|
Still missing #26651 (diff) |
GuillaumeGomez
changed the title
GuillaumeGomez
changed the title
GuillaumeGomez
changed the title
GuillaumeGomez
changed the title
| fn foo(); // error: unrecognized intrinsic function: `foo` | ||
| } | ||
|
|
||
| fn main() { |
There was a problem hiding this comment.
Do you need this function to exist in order to reproduce the error?
|
Anything else to fix/change ? |
|
Squashed. |
|
@bors r+ rollup |
|
📌 Commit be38926 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jun 30, 2015
bors
added a commit
that referenced
this pull request
Jun 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24407.
cc @michaelsproul
r? @Manishearth