Skip to content

Make AtomicPtr Send #27052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2015
Merged

Make AtomicPtr Send #27052

merged 2 commits into from
Jul 30, 2015

Conversation

wthrowe
Copy link
Contributor

@wthrowe wthrowe commented Jul 15, 2015

I think this was just missed when Send and Sync were redone, since it seems odd to not be able to use things like Arc<AtomicPtr>. If it was intentional feel free to just close this.

I used another test as a template for writing mine, so I hope I got all the headers and stuff right.

@wthrowe
Make AtomicPtr Send
fd1b030 
This appears to have just been an oversight, and it is annoying to not
be able to use an Arc<AtomicPtr>.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

tamird
tamird reviewed Jul 15, 2015
View reviewed changes
src/test/run-pass/sync-send-atomics.rs
is_sync_send(AtomicBool::default());
is_sync_send(AtomicIsize::default());
is_sync_send(AtomicUsize::default());
is_sync_send(AtomicPtr::<i32>::default());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slightly better coverage: http://is.gd/DPD5SE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I'll update my branch soon.

@wthrowe
Add regression test for atomics being Send + Sync
3a4904f 
Thanks to Tamir Duberstein for the implementation suggestion.
@Gankra
Copy link
Contributor

Gankra commented Jul 30, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 30, 2015

📌 Commit 3a4904f has been approved by Gankro

@Gankra
Copy link
Contributor

Gankra commented Jul 30, 2015

Sorry about the delay!

@bors
Copy link
Collaborator

bors commented Jul 30, 2015

⌛ Testing commit 3a4904f with merge 8b9ada5...

bors added a commit that referenced this pull request Jul 30, 2015
@bors
Auto merge of #27052 - wthrowe:atomic_send, r=Gankro
8b9ada5 
I think this was just missed when `Send` and `Sync` were redone, since it seems odd to not be able to use things like `Arc<AtomicPtr>`.  If it was intentional feel free to just close this.

I used another test as a template for writing mine, so I hope I got all the headers and stuff right.
@bors
Copy link
Collaborator

bors commented Jul 30, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 3a4904f into rust-lang:master Jul 30, 2015
@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 3, 2015
@wthrowe wthrowe deleted the atomic_send branch August 10, 2015 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wthrowe @rust-highfive @Gankra @bors @tamird @alexcrichton @brson @nikomatsakis